Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy 1.17.0 #68841

Closed
wants to merge 2 commits into from
Closed

envoy 1.17.0 #68841

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Jan 12, 2021
@carlocab
Copy link
Member

Can't bottle for ARM yet. Blocked by bazelisk

@BrewTestBot
Copy link
Member

@carlocab bottle request for bazelisk failed.

@carlocab
Copy link
Member

bazelisk seems to build on ARM, actually. It's just that the test seems to be designed to download a bazelisk ARM binary from GitHub, but this doesn't exist.

@carlocab
Copy link
Member

I wonder if we can bottle bazelisk for ARM by fixing the test?

@chenrui333
Copy link
Member Author

I wonder if we can bottle bazelisk for ARM by fixing the test?

that is the thing, bazelisk is just a wrapper to download bazel binary. If bazel does not support ARM yet, then, we cannot make it available for arm.

let me do a quick check.

@carlocab
Copy link
Member

I see, that explains why it's trying to download binaries. If they don't have any ARM binaries then there's probably nothing we can do.

@chenrui333
Copy link
Member Author

https://github.com/bazelbuild/bazel/issues/11628 is the tracker issue.

It looks like it is not that hard to build darwin_arm64, but not sure why they did not do that yet.

@chenrui333
Copy link
Member Author

chenrui333 commented Jan 12, 2021

This arm issue would technically open the door for asking all bazel versions need to be recompiled for darwin_arm64.

Depending on which bazelversion got specified, it would download specific arm edition of that bazel binary, which would require arm binary be available for that version. That sucks!! :D

@chenrui333 chenrui333 added the build failure CI fails while building the software label Jan 12, 2021
@chenrui333
Copy link
Member Author

ninja -v
ninja -v install
copy_dir_contents_to_dir $BUILD_TMPDIR/$INSTALL_PREFIX $INSTALLDIR
replace_in_files $INSTALLDIR $BUILD_TMPDIR \${EXT_BUILD_DEPS}
replace_in_files $INSTALLDIR $EXT_BUILD_DEPS \${EXT_BUILD_DEPS}
mkdir -p $EXT_BUILD_ROOT/bazel-out/darwin-fastbuild/bin/bazel/foreign_cc/copy_curl/curl
copy_dir_contents_to_dir $INSTALLDIR $EXT_BUILD_ROOT/bazel-out/darwin-fastbuild/bin/bazel/foreign_cc/copy_curl/curl
touch $EXT_BUILD_ROOT/bazel-out/darwin-fastbuild/bin/bazel/foreign_cc/empty_curl.txt
cd $EXT_BUILD_ROOT
_____ END BUILD SCRIPT _____
rules_foreign_cc: Build script location: bazel-out/darwin-fastbuild/bin/bazel/foreign_cc/curl/logs/CMake_script.sh
rules_foreign_cc: Build log location: bazel-out/darwin-fastbuild/bin/bazel/foreign_cc/curl/logs/CMake.log

Target //source/exe:envoy-static failed to build
INFO: Elapsed time: 979.353s, Critical Path: 257.58s
INFO: 3677 processes: 1249 internal, 2427 processwrapper-sandbox, 1 worker.
FAILED: Build did NOT complete successfully
FAILED: Build did NOT complete successfully

@chenrui333
Copy link
Member Author

test file got renamed per this PR

@chenrui333 chenrui333 removed the build failure CI fails while building the software label Jan 14, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 14, 2021
@chenrui333 chenrui333 deleted the bump-envoy-1.17.0 branch December 18, 2022 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants