Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonarqube: remove bottle :unneeded #79709

Closed

Conversation

nandahkrishna
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Split from #79448.

@nandahkrishna nandahkrishna added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. bottle-up-everything Make every formula bottled labels Jun 21, 2021
@BrewTestBot BrewTestBot added the java Java use is a significant feature of the PR or issue label Jun 21, 2021
@Moisan
Copy link
Member

Moisan commented Jun 21, 2021

❯ sha256sum *.tar.gz
3dcee2d9de05efa6019ea3b84e2b5625f9408663b91fa23b6a4aab10abee52f4  sonarqube--8.9.0.43852.arm64_big_sur.bottle.tar.gz
e7a9bee29eccc49d0743752a9aa98193de3f299e0f1d5f7727de020664957df0  sonarqube--8.9.0.43852.big_sur.bottle.tar.gz
e7a9bee29eccc49d0743752a9aa98193de3f299e0f1d5f7727de020664957df0  sonarqube--8.9.0.43852.catalina.bottle.tar.gz
4c49c9acea99203b6595d05b3125b99fdc4e63e473d1ee5b21b0494c70a84890  sonarqube--8.9.0.43852.mojave.bottle.tar.gz

@carlocab
Copy link
Member

carlocab commented Jun 22, 2021

The diff comes from libexec/web/js/docs.1619792615098.chunk.js and libexec/web/js/docs.m.955a5ed9.chunk.js. The text diff from diffoscope is unreadable, but the HTML one is a bit easier to read in a browser: diff.html.txt

Not really sure it's worth trying to fix this, as who knows when those filenames will change... The problematic paths start with /usr/local/share.

@cho-m
Copy link
Member

cho-m commented Jun 22, 2021

What I was curious about was diff between Mojave vs. Big Sur / Catalina, which happens in the .js.map variants of the same JS files (corresponding to same lines that ARM64 vs Big Sur has diff).

  • sonarqube/8.9.0.43852/libexec/web/js/docs.1619792615098.chunk.js.map
  • sonarqube/8.9.0.43852/libexec/web/js/docs.m.955a5ed9.chunk.js.map

It looks like Mojave has 2 more @@HOMEBREW_PREFIX@@, which are probably match the lines in .js files

  • Copy the server's CA certs to /usr/local/share/ca-certificates
  • Copy the server's CA certs to @@HOMEBREW_PREFIX@@/share/ca-certificates

I would have thought Mojave, Catalina, and Big Sur would produce same replacements.

@cho-m
Copy link
Member

cho-m commented Jun 24, 2021

Given the diff is only in the generated docs, we should probably merge this

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@nandahkrishna nandahkrishna deleted the bottle-sonarqube branch June 24, 2021 18:19
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants