Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail2ban: migrate to [email protected] #87029

Closed
wants to merge 1 commit into from
Closed

fail2ban: migrate to [email protected] #87029

wants to merge 1 commit into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Oct 10, 2021

fail2ban: migrate to [email protected]

@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue and removed deprecated license Formula uses a deprecated SPDX license which should be updated labels Oct 10, 2021
@Moisan
Copy link
Member Author

Moisan commented Oct 10, 2021

Upstream code header includes

# Fail2Ban is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.

@Moisan
Copy link
Member Author

Moisan commented Oct 10, 2021

Fails with error in fail2ban setup command: use_2to3 is invalid.

carlocab
carlocab reviewed Oct 10, 2021
View reviewed changes
Formula/fail2ban.rb Outdated Show resolved Hide resolved
@cho-m
Copy link
Member

cho-m commented Oct 10, 2021

[email protected] uses setuptools v58.2.0.
Support for 2to3 in setuptools was dropped in v58

@cho-m cho-m added the build failure CI fails while building the software label Oct 10, 2021
@cho-m
Copy link
Member

cho-m commented Oct 10, 2021

Upstream issue/fix:

@Moisan Moisan removed the build failure CI fails while building the software label Oct 11, 2021
carlocab
carlocab previously approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased to prevent @BrewTestBot from squashing the commit message to fail2ban: revision.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Nov 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Moisan @cho-m @BrewTestBot @carlocab