-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffmpeg: enable libvmaf #88959
ffmpeg: enable libvmaf #88959
Conversation
I'm going to cherry pick your commit onto #88821 so that we only have to rev bump |
# Since libvmaf v2.0.0, `.pkl` model files have been deprecated in favor of `.json` model files. | ||
inreplace f, "vmaf_v0.6.1.pkl", "vmaf_v0.6.1.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be fixed on FFmpeg master. Has this been reported upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will consult with the ffmpeg developers on whether they intend to make this configurable.
My understanding is that it is not practical to autodetect the model path, so this is left to packagers to resolve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The related issues have been reported upstream but there appears not to be any related patches in the past year.
https://trac.ffmpeg.org/ticket/9094
https://trac.ffmpeg.org/ticket/9047
Netflix/vmaf#753
Netflix/vmaf#324
Other packagers have opted to replace the path at build time. I asked in #ffmpeg-devel
and and they agreed that replacing the patch in the Homebrew formula is a reasonable solution for the time being.
Merged in b8e351f. Thanks @barrbrain! |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?The VMAF models are available since #88931 was merged, so we may enable
libvmaf
and replace the default model path. This is motivated by tools like Av1an which use the VMAF filter to evaluate and target video quality when encoding. Note that this does not expand the dependency tree of theffmpeg
formula aslibvmaf
is already a transitive dependency viaaom
.