Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@16 16.13.1 #90223

Closed
wants to merge 1 commit into from
Closed

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Dec 1, 2021

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` legacy Relates to a versioned @ formula python Python use is a significant feature of the PR or issue labels Dec 1, 2021
@Bo98
Copy link
Member

Bo98 commented Dec 1, 2021

Looks like they backported the buggy commit: nodejs/node@f778fa2. There's a PR upstream to fix it: nodejs/node#40965.

I'm testing out that patch on Node 17: #89459

@carlocab
Copy link
Member

carlocab commented Dec 3, 2021

We can probably use the same patch as the one for Node 17 here.

@derrabus
Copy link
Contributor Author

derrabus commented Dec 3, 2021

The patch works fine locally. Let's see what the CI says. 🙂

@BrewTestBot BrewTestBot removed the python Python use is a significant feature of the PR or issue label Dec 3, 2021
@derrabus
Copy link
Contributor Author

derrabus commented Dec 3, 2021

The build has passed on ARM but was cancelled on amd64 everywhere. 😢

@Bo98 Bo98 added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Dec 3, 2021
@Bo98
Copy link
Member

Bo98 commented Dec 3, 2021

Oops, I'll restart it.

@derrabus
Copy link
Contributor Author

derrabus commented Dec 3, 2021

Thanks!

@derrabus
Copy link
Contributor Author

derrabus commented Dec 4, 2021

All green! 🎉

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jan 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. legacy Relates to a versioned @ formula outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants