Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl 7.81.0 #92549

Closed
wants to merge 1 commit into from
Closed

curl 7.81.0 #92549

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Jan 5, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jan 5, 2022
@carlocab carlocab added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Jan 5, 2022
@iMichka
Copy link
Member

iMichka commented Jan 5, 2022

The Linux build was green for the previous version. Looks like 2 tests broke due to this change.

@carlocab
Copy link
Member

carlocab commented Jan 6, 2022

asuka seems unrelated. Also seen at #92531. I'm going to guess the same is true about zurl

@iMichka
Copy link
Member

iMichka commented Jan 6, 2022

I have a fix for Asuka: #92656

@iMichka
Copy link
Member

iMichka commented Jan 6, 2022

zurl works with the previous curl version, but not with this one. So this does introduce a regression somewhere.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems likely to me that the zurl is not actually broken, and that its test just needs updating.

Even if that's wrong, it seems unreasonable to delay a curl version bump to avoid breaking a formula that has had three downloads in the past year.

CC @homebrew/core in case someone has objections. (Or if someone wants to fix zurl...)

@carlocab carlocab added the help wanted Task(s) needing PRs from the community or maintainers label Jan 7, 2022
@iMichka
Copy link
Member

iMichka commented Jan 7, 2022

I have opened an issue upstream: fanout/zurl#20

@BrewTestBot
Copy link
Member

:shipit: @iMichka has triggered a merge.

@derrabus derrabus deleted the bump-curl-7.81.0 branch January 8, 2022 22:33
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 9, 2022
The version bump to curl (Homebrew#92549) is causing segfaults when installing
Julia packages. See Homebrew/discussions#2749. Upstream is already aware
of the issue (JuliaLang/Downloads.jl#172).

I've updated the test to make sure we catch this regression in the
future.
BrewTestBot pushed a commit that referenced this pull request Jan 10, 2022
The version bump to curl (#92549) is causing segfaults when installing
Julia packages. See Homebrew/discussions#2749. Upstream is already aware
of the issue (JuliaLang/Downloads.jl#172).

I've updated the test to make sure we catch this regression in the
future.

Closes #92799.

Signed-off-by: BrewTestBot <[email protected]>
@carlocab carlocab mentioned this pull request Jan 13, 2022
@carlocab carlocab mentioned this pull request Feb 2, 2022
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants