Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xapian omega 1.4.19 #96713

Closed
wants to merge 2 commits into from
Closed

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Mar 12, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

As far as I can tell, the only Python dependency in xapian is for bindings. Moreover, it requires the sphinx Python module from sphinx-doc formula. Since sphinx-doc formula is now using [email protected]:

Upstream also seems to have addressed xapian/xapian#319, but looks like a flat namespace patch is also needed (the issue in the linked PR affects the bindings, but the flat namespace issue was found in the dylib itself - so the removal of the inreplace is unrelated to the flat namespace issue).

Bump omega too; xapian and omega should be bumped together it seems (or, at least it seems each omega release requires the corresponding xapian release to be present/merged).

@alebcay alebcay force-pushed the xapian-omega-1.4.19 branch 2 times, most recently from 4187dfc to 0e3b3a2 Compare March 12, 2022 23:33
SMillerDev
SMillerDev previously approved these changes Mar 14, 2022
@carlocab carlocab added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 14, 2022
@carlocab
Copy link
Member

@alebcay feel free to merge this if you're happy with staying on [email protected].

@alebcay
Copy link
Member Author

alebcay commented Mar 14, 2022

I plan to make the adjustment later today back to [email protected], just haven't had a chance to switch it back.

@alebcay alebcay force-pushed the xapian-omega-1.4.19 branch from 0e3b3a2 to a13e863 Compare March 14, 2022 20:11
@BrewTestBot BrewTestBot removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 14, 2022
@alebcay alebcay requested a review from carlocab March 16, 2022 13:36
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I just noticed that another way to solve any dependent breakage from switching to Python 3.10 might be to also build the bindings for Python 3.9 until we've migrated the dependents. But we can consider that if/when we need to.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants