dvc 2.10.1

[pmrowla]

Created with brew bump-formula-pr.

---

This also includes a manual update to pypi_formula_mappings.json (added new bcrypt extra package)

will close iterative/dvc#7569

[SMillerDev]

This also includes a manual update to pypi_formula_mappings.json (added new bcrypt extra package)

Do they have an install target that would include this?

[pmrowla]

Do they have an install target that would include this?

Yes, the extra was left out of prior DVC brew releases by mistake (see iterative/dvc#7569)

[cho-m]

I would recommend replacing some extra_packages with corresponding pip extras_require feature name, which Homebrew supports via package_name. This would avoid having to hardcode and manually modify those dependencies.

One option would be to use all and add pyarrow to exclude:

  "dvc": {
    "package_name": "dvc[all]",
    "extra_packages": ["...TODO..."],
    "exclude_packages": ["protobuf", "pyarrow", "six", "tabulate"]
  }

Another option would be to list features out like:

  "dvc": {
    "package_name": "dvc[azure,gdrive,gs,oss,s3,ssh,webdav]",
    "extra_packages": ["...TODO..."],
    "exclude_packages": ["protobuf", "six", "tabulate"]
  }

This will help pick up new dependencies like the missing ossfs.

Ideally, there shouldn't be any extra_packages, but can add oss2 to avoid picking older oss2 that needs aliyun-python-sdk-core-v3.

[pmrowla]

I would recommend replacing some extra_packages with corresponding pip extras_require feature name, which Homebrew supports via package_name. This would avoid having to hardcode and manually modify those dependencies.

👍

Thanks, specifying dvc[all] this way looks like what we want, we just weren't aware that it actually supported pip extras in this way

[pmrowla]

PR has been updated to use package_name: dvc[all].

One thing to note is that this still requires passing an additional jmespath<1.0 into pipgrip in order for it to resolve DVC's dependencies properly (see Homebrew/brew#13147 and the other linked issues there)

[cho-m]

One thing to note is that this still requires passing an additional jmespath<1.0 into pipgrip in order for it to resolve DVC's dependencies properly (see Homebrew/brew#13147 and the other linked issues there)

I wonder if it would be worth enhancing extra_packages to support > and < constraints (I think it only supports unversioned and exact version == right now).

It looks like oss2 v2.14+ no longer uses aliyun-python-sdk-core-v3 (aliyun/aliyun-oss-python-sdk@7c1a93a). Assuming rest of dependency tree is okay, then doing oss2>=2.14.0 should avoid problematic packages.

[BrewTestBot]

@cho-m has triggered a merge.