Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portable-ruby 3.4.2 #285

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

portable-ruby 3.4.2 #285

wants to merge 3 commits into from

Conversation

BrewTestBot
Copy link
Member

@BrewTestBot BrewTestBot commented Feb 15, 2025

Created by brew bump


Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@p-linnane
Copy link
Member

@Bo98 Everything looks good here except for the expected error on El Capitan.

@p-linnane p-linnane force-pushed the bump-portable-ruby-3.4.2 branch from 21b77ff to 5106526 Compare February 25, 2025 18:28
@MikeMcQuaid
Copy link
Member

@Bo98 Everything looks good here except for the expected error on El Capitan.

@p-linnane @Bo98 what's expected about the error here? Missing context.

@p-linnane
Copy link
Member

Per Bo on the previous PR:

This has however been useful in revealing a bug on older macOS so will look into upstreaming a fix for that.

I have no other info than that.

@EricFromCanada
Copy link
Member

It's a usage of clock_gettime which, as we all remember, was only implemented in macOS 10.12. It's been patched before, but doesn't look like a PR has been issued so far.

@p-linnane
Copy link
Member

Would it not make more sense to drop El Capitan support if this a recurring issue?

Signed-off-by: Patrick Linnane <[email protected]>
@Bo98
Copy link
Member

Bo98 commented Feb 26, 2025

Yeah lost track of this with all the AGM stuff.

Patch would be fairly trivial but 10.11 was on track for being dropped if we end up using copyfile (not in Ruby 3.4 though, maybe 3.5).

We can drop 10.11 but I'll need to update the CI images to 10.12 which could be done on the 11th March maintenance window. And then coordinate Homebrew 4.5.0 to happen with that and the Ruby 3.4 minimum version bump. It's more work than patching but probably was going to happen eventually anyway.

@p-linnane
Copy link
Member

Let's just patch for now since it's trivial. Better than rushing with everything else that needs to happen.

@MikeMcQuaid
Copy link
Member

@Bo98 I'd also consider patching to be better her but if the CI images are changing anyway: feel free to do that instead. Would like to have this merged before end of March if at all possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants