-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portable-ruby 3.4.2 #285
base: master
Are you sure you want to change the base?
portable-ruby 3.4.2 #285
Conversation
@Bo98 Everything looks good here except for the expected error on El Capitan. |
Signed-off-by: Patrick Linnane <[email protected]>
21b77ff
to
5106526
Compare
@p-linnane @Bo98 what's expected about the error here? Missing context. |
Per Bo on the previous PR:
I have no other info than that. |
It's a usage of |
Would it not make more sense to drop El Capitan support if this a recurring issue? |
Signed-off-by: Patrick Linnane <[email protected]>
Yeah lost track of this with all the AGM stuff. Patch would be fairly trivial but 10.11 was on track for being dropped if we end up using We can drop 10.11 but I'll need to update the CI images to 10.12 which could be done on the 11th March maintenance window. And then coordinate Homebrew 4.5.0 to happen with that and the Ruby 3.4 minimum version bump. It's more work than patching but probably was going to happen eventually anyway. |
Let's just patch for now since it's trivial. Better than rushing with everything else that needs to happen. |
@Bo98 I'd also consider patching to be better her but if the CI images are changing anyway: feel free to do that instead. Would like to have this merged before end of March if at all possible. |
Created by
brew bump
Created with
brew bump-formula-pr
.resource
blocks have been checked for updates.