Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keyword_argument to FormulaInstaller#new #792

Merged
merged 1 commit into from
Mar 7, 2022
Merged

add keyword_argument to FormulaInstaller#new #792

merged 1 commit into from
Mar 7, 2022

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Mar 5, 2022

added keyword argument build_bottle to FormulaInstaller.new in order to delete attr_writer to be deleted which is stated in the comment https://github.com/Homebrew/brew/blob/master/Library/Homebrew/formula_installer.rb#L45

@MikeMcQuaid MikeMcQuaid merged commit 4286a36 into Homebrew:master Mar 7, 2022
@MikeMcQuaid
Copy link
Member

Thanks @hyuraku!

@hyuraku hyuraku mentioned this pull request Mar 7, 2022
Merged
7 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyuraku @MikeMcQuaid