Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Resource Groups with "Region-less" Naming Convention? #100

Closed
bdschaap opened this issue Jul 5, 2019 · 3 comments
Closed

Support Resource Groups with "Region-less" Naming Convention? #100

bdschaap opened this issue Jul 5, 2019 · 3 comments

Comments

@bdschaap
Copy link
Contributor

bdschaap commented Jul 5, 2019

I'm defining some centralized resources (not region specific). One is for ActionGroups which use a 'Global' location. The other is for Application Insights and we're centralizing telemetry in a single region. I'd appreciate any thoughts on whether to allow resource groups to optionally include the region in the naming convention. It's supported for resources but not resource groups.

It should be possible to do this by using an expression for the rgOverride field but #93 would need to be addressed.

@bdschaap
Copy link
Contributor Author

@csperbeck brought this up again when reviewing one of my Azure resource deployments

@whilke
Copy link
Member

whilke commented Jul 26, 2019

This is already supported coreutils.resource_group(, false)

you'll get RG___

notice the two __ between name and env since we are not setting a region code string. Someone could submit a PR to fix that to a single _ if rgn is not set in _create_resource_group_name

@whilke whilke closed this as completed Jul 26, 2019
@whilke whilke reopened this Jul 26, 2019
@whilke
Copy link
Member

whilke commented Jul 26, 2019

Reopening because I understand what you are talking about now. You want the package auto RG creation to support a region-less creation option. Fix inc.

whilke added a commit that referenced this issue Jul 26, 2019
fix: changing resource group naming schema

fix: adding support for a region-less RG name create set: rgOverride: "[coreutils.resource_group(null,false,null,true)]"
@whilke whilke closed this as completed Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants