This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Adjustment types for inventory need to localized #390
Labels
Comments
jkleinsc
added
Inventory
help wanted
indicates that an issue is open for contributions
localization
labels
Mar 21, 2016
dswanson
added
the
in progress
indicates that issue/pull request is currently being worked on
label
May 18, 2016
Working on this issue at OSCON Contribute! |
tangollama
removed
the
help wanted
indicates that an issue is open for contributions
label
May 18, 2016
ye this is something i have been thinking about as well. @dswanson i presume you haven't made any progress on this ? |
tangollama
added
the
help wanted
indicates that an issue is open for contributions
label
Mar 14, 2017
Going to start looking at this issue. |
@sweeneydavidj go for it. I'll set the issue to In Progress. If for some reason you can't complete this issue, let me know and I'll update the status on the issue. |
jkleinsc
removed
the
help wanted
indicates that an issue is open for contributions
label
Mar 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Expected behavior: Inventory adjustment types display localized text.
Actual behavior: Inventory adjustment types display hard coded text. Right now values displayed for adjustment types are hard coded in app/mixins/inventory-adjustment-types.js
Steps to reproduce: Edit an inventory item and click on the adjust button. The adjustment type dropdown and the button at the bottom of the modal are being pulled directly from the mixin.
One thing to keep in mind with this issue is that the 'Type' values in the mixin is used in the code and gets saved to to the database, so those values should not be localized, but anywhere we display those "type" values we need to localize them.
The text was updated successfully, but these errors were encountered: