Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adjustment types for inventory need to localized #390

Closed
jkleinsc opened this issue Mar 21, 2016 · 5 comments
Closed

Adjustment types for inventory need to localized #390

jkleinsc opened this issue Mar 21, 2016 · 5 comments
Labels
in progress indicates that issue/pull request is currently being worked on localization

Comments

@jkleinsc
Copy link
Member

jkleinsc commented Mar 21, 2016

Expected behavior: Inventory adjustment types display localized text.

Actual behavior: Inventory adjustment types display hard coded text. Right now values displayed for adjustment types are hard coded in app/mixins/inventory-adjustment-types.js

Steps to reproduce: Edit an inventory item and click on the adjust button. The adjustment type dropdown and the button at the bottom of the modal are being pulled directly from the mixin.

One thing to keep in mind with this issue is that the 'Type' values in the mixin is used in the code and gets saved to to the database, so those values should not be localized, but anywhere we display those "type" values we need to localize them.

@jkleinsc jkleinsc added Inventory help wanted indicates that an issue is open for contributions localization labels Mar 21, 2016
@dswanson dswanson added the in progress indicates that issue/pull request is currently being worked on label May 18, 2016
@dswanson
Copy link

Working on this issue at OSCON Contribute!

@tangollama tangollama removed the help wanted indicates that an issue is open for contributions label May 18, 2016
@dswanson
Copy link

image

@billybonks
Copy link
Contributor

ye this is something i have been thinking about as well. @dswanson i presume you haven't made any progress on this ?

@tangollama tangollama added the help wanted indicates that an issue is open for contributions label Mar 14, 2017
@sweeneydavidj
Copy link
Contributor

Going to start looking at this issue.

@jkleinsc
Copy link
Member Author

@sweeneydavidj go for it. I'll set the issue to In Progress. If for some reason you can't complete this issue, let me know and I'll update the status on the issue.

@jkleinsc jkleinsc removed the help wanted indicates that an issue is open for contributions label Mar 24, 2017
jkleinsc pushed a commit that referenced this issue Apr 3, 2017
…ed (#1041)

* Address issue #390, Adjustment types for inventory need to be localized

* Adustment types need to be localized; reorganized localization values.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on localization
Projects
None yet
Development

No branches or pull requests

5 participants