-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anisha1234 thanks for the PR. It looks like some of the code from your other PR #983 is in this PR.
As far as a production build for docker, the intention is that running HospitalRun in production should use https://github.com/HospitalRun/hospitalrun-server instead of hospitalrun-frontend, so if someone wants to run Docker for production, then we should do work in the https://github.com/HospitalRun/hospitalrun-server repo to accommodate that.
app/styles/_variables_mixins.scss
Outdated
@@ -21,6 +21,7 @@ $blue_lightest: #eff2f5; | |||
$blue_lightest2: #dee2e7; | |||
$red: #ff6d6f; | |||
$red_light: rgba($red,.3); | |||
$red_lighter: rgba($red,.75); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes appear to be for another PR and shouldn't be in this one.
app/styles/components/_buttons.scss
Outdated
@@ -1,17 +1,17 @@ | |||
.btn { | |||
&.on-white { | |||
background-color: $blue_light; | |||
color: $navy; | |||
background-color: #00c4a2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes also appear to be for a different PR.
@anisha1234 thanks for updating this PR. I am going to merge it in. The hospitalrun-server work should be done in that repo. I just checked and eHealth Africa has been working on this: https://github.com/eHealthAfrica/hospitalrun-server/tree/conf/docker |
Fixes #980
Changes proposed in this pull request:
Work in progress
cc @jkleinsc @jglovier @tangollama