This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Update ember-concurrency to the latest version 🚀 #1029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.8.0 of ember-concurrency just got published.
The version 0.8.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ember-concurrency.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
perf + sync start0.8.0
has been rewritten to be more performant, but to also
more immediately start executing task functions. Prior
to this version,
perform()
ing a task wouldn't actuallystart executing the task function until the
actions
queueon the run loop; this behavior was inconsistent with the timing
of async functions, and meant that certain lifecycle hooks
that depended on logic being run synchronously couldn't be
used with ember-concurrency Tasks (because they already
missed their window of execution). This is unlikely to
break anyone's apps, but it's possible some apps out there
have subtle timing dependencies on tasks running within
run loop queues, so it's better to announce this as a possible
breaking change. (#107)
isSuccessful
andisError
property (#119)performCount
that trackshow many times a task has been performed.
a jQuery / Ember event occurs, or until a particular
run loop queue has been reached.
Commits
The new version differs by 41 commits .
73e0684
add some links to Changelog
b9a2916
0.8.0
c397852
document waitForEvent
4cec2f2
add more to Derived State docs
66bbf1a
add Task.performCount
a03ddd4
fixed font-awesome build issues
f77dac6
Merge branch 'patch-1' of https://github.com/Cryrivers/ember-concurrency into Cryrivers-patch-1
8a634a5
yieldables -> cancelable-promise-helpers
9f6fc6e
Slight grammatical tweak (#118)
b9341d5
use yieldables API for waitForEvent / waitForQueue
a8c44bd
Merge branch 'run-loop' of https://github.com/offirgolan/ember-concurrency into offirgolan-run-loop
7dac5d2
Update to ember-cli-babel@6. (#127)
716a8ce
don't try so hard
ff775fa
fix last remaining taskGroup bug
3dec22e
updater ember-cli, task group bugs almost fixed
There are 41 commits in total. See the full diff.
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴