Translation refactor #959
Translation refactor #959
Conversation
Refactor for labs and pricing
refactor users translation
translate diagnosis
refactor imaging
Clean/labs
There was a problem hiding this comment.
Thanks @billybonks, @gabrielle-ong, and @RenchChua for this PR. I think if we can resolve the issue around placeholders this PR will be good to go. I do think I'll setup a new branch to merge this into until the whole refactor is done.
| visit: 'Visit', | ||
| status: 'Status' | ||
| }, | ||
| placeholders: { |
There was a problem hiding this comment.
@billybonks I'm not sure about calling this a placeholder. It is a valid option to select, not a temporary placeholder value. When you select/leave this option a new visit is created, so there is action firing based on its selection/non selection.
app/locales/en/translations.js
Outdated
| @@ -1278,6 +1278,27 @@ export default { | |||
| appointmentDate: 'Date' | |||
| } | |||
| }, | |||
| labs: { | |||
There was a problem hiding this comment.
Hey, I'm interested in helping out with the translations. Wondering why labs is pluralized when pricing is singular?
There was a problem hiding this comment.
jk. just saw the fix in the later commit
|
@billybonks I have been waiting to merge this in until the placeholder issue I brought up is resolved. I'm fine waiting on it, but just thought I would ping you to make sure we are on the same page on this one. |
|
@billybonks bump. :) |
Translate Invoice
|
@jkleinsc I think this is ready to go, but I'll leave that to you. |
|
@tangollama @billybonks I had asked that the "placeholder" label be changed. That I can see, it has not been changed. |
|
@billybonks closing this PR for now. Feel free to re-open when/if it makes sense. |
Works on #547
This updates
A few different modules ported over.
Text stays relatively the same, there is a pull request/s in the works for:
the last remaining module is
The main goal here it easy to know where translations belong, i will be typing out some documentation upon completion of the port.
This is a breaking change for locales i am not sure if they are deployed somewhere if you would like to make a locale refactor branch to merge into i will be happy to do that.
i will implement transfix as soon as the refactor is completion.
thanks to @gabrielle-ong and @RenchChua