-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harden Windows Security v0.7.1 #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated TLS category Intune JSON Formatting because Intune's schema was updated.
Results of the MDM data that are not used by the module will no longer be collected, improving the compliance checking performance.
This was
linked to
issues
Jan 2, 2025
1 task
Added support for verifying keys that shouldn't exist.
Removing Optimize+ speeds up the compilation
No longer depends on WDACConfig, everything is included natively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (15)
- Harden-Windows-Security Module/Main files/Harden-Windows-Security-Module.psd1: Language not supported
- Harden-Windows-Security Module/Main files/Harden-Windows-Security-Module.psm1: Language not supported
- Harden-Windows-Security Module/Main files/Resources/Dangerous-Script-Hosts-Blocking.xml: Language not supported
- Harden-Windows-Security Module/Main files/Resources/Downloads-Defense-Measures.xml: Language not supported
- Harden-Windows-Security Module/Main files/Resources/MDMResultClasses.csv: Language not supported
- Harden-Windows-Security Module/Main files/Resources/Registry resources.csv: Language not supported
- Harden-Windows-Security Module/Main files/Resources/XAML/Protect.xaml: Language not supported
- Harden-Windows-Security Module/version.txt: Language not supported
- Harden-Windows-Security Module/Main files/C#/Types/CiPolicyInfo.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/GUI/Protection/Variables.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/Unprotect Methods/UnprotectWindowsSecurity.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/CimInstances/MDM.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/GUI/Protection/EventHandlers.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/Protect Methods/TLSSecurity.cs: Evaluated as low risk
- Harden-Windows-Security Module/Main files/C#/Others/CategoryProcessing.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
Harden-Windows-Security Module/Main files/C#/Protect Methods/TLSSecurity_BattleNetClient.cs:17
- [nitpick] The exception message could be more descriptive. Consider changing it to 'GlobalVars.path cannot be null in TLSSecurity_BattleNetClient method.'
throw new ArgumentNullException("GlobalVars.path cannot be null.");
Harden-Windows-Security Module/Main files/C#/Protect Methods/TLSSecurity_BattleNetClient.cs:12
- The new behavior introduced by the TLSSecurity_BattleNetClient method is not covered by tests.
public static void TLSSecurity_BattleNetClient()
Updated the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New
During the compliance checking, MDM results that are not used by the module are no longer collected, improving the performance and speed, especially on lower end hardware.
Adjusted the TLS Category's Intune Json config to match the new schema.
Added a new sub-category for the TLS category, called "TLS for BattleNet". When selected, the TLS category will deploy the group policy that has the extra cipher suite
TLS_RSA_WITH_AES_256_CBC_SHA
which is less secure but required for BattleNet client to connect to its servers. Fixes -> [BUG?]: TLS Security fix for Battle.net not working #489WDACConfig module is no longer used/installed for Downloads Defense Measures category. All the necessary logic for policy creation is now implemented natively. This substantially improves the performance and allows for full offline usage of this category and its sub-categories.