Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#188[fix] 개강 업데이트 전 수정사항 반영 #189

Merged
merged 4 commits into from
Feb 21, 2023
Merged

#188[fix] 개강 업데이트 전 수정사항 반영 #189

merged 4 commits into from
Feb 21, 2023

Conversation

KWY0218
Copy link
Member

@KWY0218 KWY0218 commented Feb 10, 2023

관련 이슈

KakaoTalk_20230210_235805382.mp4
KakaoTalk_20230210_235630538.mp4

작업한 내용

  • splash 로티 변경
  • 성향 테스트 후 결과 대기시간 view 2초에서 1초로 수정
  • 성향테스트 문항 선택 시 컬러 red 에서 blue로 수정

PR 포인트

  • 성향 테스트 수정할 때 xml 찾는데 파일 왔다리 갔다리 하니까 컴포즈 그립더라고요..

@KWY0218 KWY0218 added 원용🐉 원용이가 작업함! fix 수정 Pull Request🔥 풀리퀘 날림! labels Feb 10, 2023
@KWY0218 KWY0218 requested a review from a team February 10, 2023 14:59
@KWY0218 KWY0218 self-assigned this Feb 10, 2023
2zerozu
2zerozu approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@2zerozu 2zerozu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xml 사랑합니다

murjune
murjune approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 이제 봤네 ㅋㅋㅋㅋ 고생했슈~

yjooooo
yjooooo approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@yjooooo yjooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하느라 고생하셨습니다!

@KWY0218 KWY0218 merged commit 1c3e55c into develop Feb 21, 2023
@KWY0218 KWY0218 deleted the feature/188-edit-detail branch February 21, 2023 05:06
@2zerozu 2zerozu added this to the Hous 2차 릴리즈 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjooooo yjooooo yjooooo approved these changes

@2zerozu 2zerozu 2zerozu approved these changes

@murjune murjune murjune approved these changes

Assignees

@KWY0218 KWY0218

Labels
fix 수정 Pull Request🔥 풀리퀘 날림! 원용🐉 원용이가 작업함!
Projects
None yet
Milestone
Hous 2차 릴리즈
Development

Successfully merging this pull request may close these issues.

[fix] 개강 업데이트 전 수정사항
4 participants
@KWY0218 @yjooooo @2zerozu @murjune