Fix ip-sticky example hanging #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent master process reading from socket which cause hanging we have to pause connection and manualy resume when child_process will be ready to process it. Mentions in Node.js documentation here [net.createSerer](https://nodejs.org/api/net.html#netcreateserveroptions-connectionlistener) ``` If pauseOnConnect is set to true, then the socket associated with each incoming connection will be paused, and no data will be read from its handle. This allows connections to be passed between processes without any data being read by the original process. To begin reading data from a paused socket, call socket.resume(). ``` The issue resolved with a help of following issue: nodejs/node#13435
tshemsedinov
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Thank you! @JaoodxD Looks like the code is outdated. It worked before, but probably not always reliable. We didn’t have a load test to check reliability and bug may be floating. According to the documentation, it looks like the flag is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent master process reading from socket which cause hanging we have to pause connection and manually resume when child_process will be ready to process it.
Mentions in Node.js documentation here net.createServer
The issue resolved with a help of following issue: nodejs/node#13435