Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned multi-turn base and base-gt (model score file line 90-120) #9

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Cleaned multi-turn base and base-gt (model score file line 90-120) #9

merged 2 commits into from
Oct 17, 2024

Conversation

VishnuSuresh27
Copy link
Collaborator

No description provided.

Fanjia-Yan
Fanjia-Yan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@Fanjia-Yan Fanjia-Yan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vishnu, mostly look good to me. One question: for booking ID change, have you tested that the id generation is deterministic? Do you have a good understanding of why previously is wrong?

@VishnuSuresh27
Copy link
Collaborator Author

Hey Fanjia, yes the booking id generation process is deterministic. The ground truth files were outdated and therefore the booking ids were misaligned with the new state of the travel-booking API.

@Fanjia-Yan
Copy link
Collaborator

@HuanzhiMao Can merge this

@HuanzhiMao HuanzhiMao merged commit 9707e55 into HuanzhiMao:multi_turn_dataset_fix Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fanjia-Yan Fanjia-Yan Fanjia-Yan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VishnuSuresh27 @Fanjia-Yan @HuanzhiMao