Configurable file_descriptors limit for warden container #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shashidharatd
force-pushed
the
hwcf-issue-2
branch
3 times, most recently
from
d02025b to
2e850af
Compare
…yed_unbind [#83710826]
We also removed tests from client_spec that tested error handling in favor of testing that logic in the response_parser_spec
[#83710826]
…errors folder includes corresponding namespacing VCAP::Services::ServiceBrokers::V2::Errors::*
[finishes #83710826]
- format is not set in stone - should be added to processes so we can factor out shared code. [#79989902]
[#79989902]
[finishes #83710822]
- Instances can modify export_attrs at runtime - PaginatedCollections can now have a transformer to modify records - UaaClient can fetch usernames for user guids [#63345104]
[#63345104]
[finishes #84874928]
Tests the result, instead of making assertions about the nested jobs
[finishes #84874912]
* This only effects deployments that have run migrations prior to bb642ff [#82509564]
We only need to support description field [finishes #80794268]
…oid automatic retry on timeout [finishes #84037538]
* anything else will be treated as false * Do not need to special case tinyint columns as Sequel does the * conversion for us [#84942534]
…ll it directly [finishes #84895424]
* All you need to specify is the DB env var * i.e. `DB=mysql rake db:dev:migrate` [#76726312]
…ndered to users as a 502 We should never return 500 for an expected error [#84963628] [#85739060]
This is sort of testing configuration, but it has value in that having a method called response_code causes different behavior in the error presenter, and we want to make sure this code conforms to that interface [finishes #84963640]
* includes polling instance state * includes recovering from failed state * includes recovering from DB errors [#84254704]
Because we are no longer using Struct.new, we lost some behavior that we previously got for free. Most importantly, Struct.new initializers allow all arguments to be optional. We chose to make only a few of these arguments optional in our change; only initializers that are ever actually invoked with fewer arguments retain the originial method signature. Another interesting change is that Struct redefines equality: two structs are equal if all of their fields are equal. We've removed any attempt to depend on that functionality.
[finishes #83710826] [finishes #83710822]
Full revert list is: da665b7 - Decrease sensitivity on time based test (5 days ago) <JT Archie and Luan Santos> 0cdb27e - Fix incompatibility with MySQL 5.5 when setting timezone (6 days ago) <JT Archie and Luan Santos> 72a6713 - Fix rubocop offense (6 days ago) <JT Archie and Luan Santos> de41ab8 - Fix flaky time dependent test (6 days ago) <JT Archie and Luan Santos> eda570d - Fix time consistency, use DB time where possible (7 days ago) <Luan Santos and Sujoy Basu> [#82077856] Conflicts: spec/unit/controllers/internal/bulk_apps_controller_spec.rb
- flow network egress rules for staging and desiring [#79330234] Signed-off-by: Hristo Iliev <[email protected]> Signed-off-by: Atul Kshirsagar <[email protected]>
shashidharatd
force-pushed
the
hwcf-issue-2
branch
from
2e850af to
1192066
Compare
file_descriptors for a warden container is made configurable through deployment manifest. Currently the default is 16384 which is read from the database table and is not configurable. To configure, cf operator needs to add the following config variable under cc cc: container_file_descriptor_limit: 4096 [#82011156]
shashidharatd
force-pushed
the
hwcf-issue-2
branch
from
1192066 to
2f39533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file_descriptors for a warden container is made configurable through
deployment manifest.
Currently the default is 16384 which is read from the database table
and is not configurable. To configure, cf operator needs to add the
following config variable under cc
cc:
default_app_file_descriptors: 4096
[#82011156]