Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hs create global-partial error message causing confusion #502

Closed
TheWebTech opened this issue May 17, 2021 · 0 comments · Fixed by #503
Closed

hs create global-partial error message causing confusion #502

TheWebTech opened this issue May 17, 2021 · 0 comments · Fixed by #503
Labels
bug Something isn't working

Comments

@TheWebTech
Copy link
Contributor

This error message is causing confusion for developers. It reads as if we deprecated global partials. In reality it's meaning the separate command was deprecated. Developers should be using global partials when it makes sense, and they are not deprecated.

hubspot-cli/packages/cli/commands/create.js

Line 155 in 98ebf65

`The asset type ${assetType} has been deprecated. Please choose the "template" asset and select "global partial".`

@TheWebTech TheWebTech added the bug Something isn't working label May 17, 2021
TheWebTech added a commit that referenced this issue May 17, 2021
@TheWebTech
resolves #502 by providing better error messaging.
0761a47
@TheWebTech TheWebTech mentioned this issue May 17, 2021
Merged
TheWebTech added a commit that referenced this issue May 17, 2021
@TheWebTech
Merge pull request #503 from HubSpot/hotfix/502-global-partial-command
0b1b183 
resolves #502 by providing better error messaging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #502 by providing better error messaging. HubSpot/hubspot-cli
1 participant
@TheWebTech