Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion script #342

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Add autocompletion script #342

merged 3 commits into from
Oct 13, 2020

Conversation

drewjenkins
Copy link
Contributor

Take advantage of yargs autcompletion script. I was looking to see if there was a way to modify the output so we could add a bit more detail about the installation instructions but I couldn't find anything in the docs about it.

2020-10-05 12 55 55

@drewjenkins drewjenkins self-assigned this Oct 5, 2020
@drewjenkins
Copy link
Contributor Author

Resolves #321

Copy link
Contributor

@anthmatic anthmatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth throwing a note in the readme about this. FWIW, the completion script guessed the wrong config file for my (.bashrc instead of .zshrc) which is probably an issue on my end, but worth noting.

Otherwise, LGTM!

@drewjenkins
Copy link
Contributor Author

It might be worth throwing a note in the readme about this. FWIW, the completion script guessed the wrong config file for my (.bashrc instead of .zshrc) which is probably an issue on my end, but worth noting.

Otherwise, LGTM!

That's surprising to me. It's the library doing all of that detection. Is your default shell zsh? I would assume it goes off of that. Like maybe if you are using iterm, but Mac's terminal is still on bash?

@drewjenkins drewjenkins merged commit 20e4ac5 into master Oct 13, 2020
@drewjenkins drewjenkins deleted the auto-completion branch October 13, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants