hs list command to check contents of directories #354
Conversation
|
Nice! Re: grouping, I do think something there would be beneficial. Maybe some way to differentiate between folders and files? |
I was thinking of changing the output to look for a file extension and then assume that if one exists(minus special case of
|
miketalley
changed the title
|
2 things I noticed, neither of which are deal breakers:
|
|
|
Re: the order, this is what I see (with other folders that start with "c") vs
|
|
Fixed the incorrect sorting and pinned @HubSpot and @marketplace folders to top of the list |
|
@anthmatic I filed an issue for the filemapper endpoint to include the |
packages/cms-cli/commands/ls.js
Outdated
| return fileOrFolder; | ||
| } | ||
|
|
||
| return `/${fileOrFolder}`; |
There was a problem hiding this comment.
Is there a particular reason for prepending / to some items but not others? If we decide to keep this logic, one thing to keep in mind is that modules also have a postfix (e.g. .module.
There was a problem hiding this comment.
This was done to make it clearer which items are folders(prepended with /) and which are files.
There was a problem hiding this comment.
Looks like it works properly with modules
There was a problem hiding this comment.
Isn't mymodule.module a folder?
There was a problem hiding this comment.
I was trying to mimic the display of the finder in DM where modules are listed more like files, but that is a good point -- it should be listed like a folder.
miketalley
changed the title
|
I wonder if we should borrow from |
packages/cms-cli/commands/list.js
Outdated
| mappedContents | ||
| .sort(function(a, b) { | ||
| // Pin @hubspot folder to top | ||
| if (a === hubspotFolder) { |
There was a problem hiding this comment.
With the other changes, does this still work?
There was a problem hiding this comment.
Yes, it looks to be pinning these folders to the top.
Note: The BE is not currently returning the @hubspot folder(I've filed an issue for this in the filemapper repo).
I tested with the following code...
contentsResp = await getDirectoryContentsByPath(portalId, directoryPath);
const randomIndex = Math.floor(
Math.random() * contentsResp.children.length
);
contentsResp.children.splice(randomIndex, 0, '@hubspot');
There was a problem hiding this comment.
Were you testing with a root directory that had folders starting with numbers such as 1folder?
|
Updated output to use Another potential that I looked into was using sprintf to create columns and having a column after the folder name indicating
I believe that using color to distinguish folders is the simplest and clearest solution and is less confusing than
|
|
We are using |
Description and Context
New command
hs list [path]allows listing directory contents by path. Default path is root. Aliased ashs ls [path].Screenshots
Questions
Do we want to group folders/files and output folders first(perhaps withDone/prefix)?Any other changes to the output(I made this as MVP as possible for now)?
Do we want to look at the BE endpoint to increase speed(it's a bit slow ATM)?
TODO
Filed issue with fileMapper to include
@hubspotfolder in list of contents returned from endpoint.Who to Notify
/cc @TheWebTech