Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label in module creation flow #413

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix label in module creation flow #413

merged 1 commit into from
Jan 11, 2021

Conversation

anthmatic
Copy link
Contributor

Description and Context

Fixes #395

Previously, the create module command would prompt for a label value but not correctly set it in the meta.json file

Screenshots

image

@anthmatic anthmatic merged commit 041b40f into cms-cli Jan 11, 2021
@anthmatic anthmatic deleted the fix/create-module-label branch January 11, 2021 16:21
@anthmatic anthmatic restored the fix/create-module-label branch January 11, 2021 16:39
@anthmatic anthmatic mentioned this pull request Jan 11, 2021
Merged
@anthmatic anthmatic deleted the fix/create-module-label branch January 14, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcorne gcorne gcorne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthmatic @gcorne