Fix for mocked data values and server exit callback #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d updated value of HUBSPOT_CONTACT_LIST_MEMBERSHIPS to mimic .env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This PR adds a
HUBSPOT_ACCOUNT_IDwhich can be obtained automatically when using the CLI to run the serverless-dev-runtime, but should have a default value when running it by importing.This PR also updates the
HUBSPOT_CONTACT_LIST_MEMBERSHIPSmock value from[]to''to match the way it should be set in the.envand updatesdata.jsto consume the values the same way, simplifying logic.Lastly, a callback can now be passed to
currentServer.exitif logic needs to wait for the server to shutdown.