Adding initial support for project deploys #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketalley
requested review from
drewjenkins and
brandenrodgers
and removed request for
drewjenkins and
brandenrodgers
miketalley
force-pushed
the
issues/285-initial-env-support
branch
from
32696af to
653ae48
Compare
anthmatic
reviewed
Apr 27, 2021
| */ | ||
| function getFileMapperApiQueryFromMode(mode) { | ||
| function getFileMapperQueryValues({ mode, options = {} }) { |
| logger.error(`Deploy error: ${deployResp.error.message}`); | ||
| } | ||
|
|
||
| logger.success( |
There was a problem hiding this comment.
Will we show the success message here even if there is an error?
brandenrodgers
approved these changes
Apr 27, 2021
drewjenkins
reviewed
Apr 27, 2021
drewjenkins
reviewed
Apr 27, 2021
drewjenkins
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/285
This PR adds the command
hs project deploy <projectFolderPath>and adds a--stagingflag to thehs fetchcommand that will add the paramenvironmentId=2to the request (default is1).Note
--stagingassets in the project folder, there will be an error output for every file that is live in the project folder. I spoke to @liamrharwood and he let me know there is a known BE issue dealing with fetching a folder as opposed to a file from thecontent/filemapper/v1/download/${folderPath}endpoint. Hopefully this will no longer occur when that bug is fixed, as it looks like we are passing theenvironmentId: 2properly to that endpoint when fetching.Who to Notify
@liamrharwood