Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove to limit notifications to the most relevant #457

Merged
merged 2 commits into from
Apr 6, 2021
Merged

remove to limit notifications to the most relevant #457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19aa374
rm completed logs
ksvirkou-hubspot Mar 26, 2021
40bd953
switch to the debug level
ksvirkou-hubspot Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/cli-lib/projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ async function downloadProject(
encoding: null,
headers: { ...DEFAULT_USER_AGENT_HEADERS },
});
logger.log('Completed project fetch.');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth it to keep these and switch to the debug level (logger.debug) to aid in troubleshooting in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do it because I switch level on my local machine but it prints debug messages

return zip;
} catch (err) {
logger.error('An error occured fetching the project source.');
Expand Down Expand Up @@ -124,7 +123,6 @@ async function extractProjectZip(repoName, zip) {
logErrorInstance(err);
return null;
}
logger.log('Completed project source extraction.');
return { extractDir, tmpDir };
}

Expand All @@ -141,7 +139,6 @@ async function copyProjectToDest(src, sourceDir, dest) {
const rootDir = files[0];
const projectSrcDir = path.join(src, rootDir, sourceDir);
await fs.copy(projectSrcDir, dest);
logger.log('Completed copying project source.');
return true;
} catch (err) {
logger.error(`An error occured copying project source to ${dest}.`);
Expand Down