Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new approach for custom object schemas behind a flag #475

Merged
merged 7 commits into from
Apr 29, 2021

Conversation

gcorne
Copy link
Contributor

@gcorne gcorne commented Apr 22, 2021

Description and Context

This PR starts the process of implementing a more robust approach for working with custom object schemas that incorporates property groups and associations.

It introduces a top-level config flag useCustomObjectHubfile that is used to determine whether to use the old or new approach.

TODO

  • Implement flow for getting a schema as a file
  • Adjust backend to provide more useful response so we can better log successes
  • Automatically detect the shape of the file when determining what logic branch to use

Who to Notify

@chrisbaldauf @drewjenkins @brandenrodgers

@gcorne gcorne marked this pull request as ready for review April 28, 2021 21:28
@@ -142,9 +142,9 @@ const getOrderedConfig = unorderedConfig => {
...(defaultPortal && { defaultPortal }),
defaultMode,
httpTimeout,
allowsUsageTracking,
portals: portals.map(getOrderedAccount),
allowUsageTracking,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gcorne gcorne merged commit 2ca0f44 into master Apr 29, 2021
@gcorne gcorne deleted the update-schemas branch April 29, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants