Add hack to deal with videos in Oculus Browser when exiting VR mode #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,10 +458,11 @@ export default class SceneEntryManager { | |||
| if (entry.type === "scene_listing" && this.hubChannel.permissions.update_hub) return; | |||
|
|
|||
| // If user has HMD lifted up, delay spawning for now. eventually show a modal | |||
| const delaySpawn = isIn2DInterstitial() && !isMobileVR; | |||
| const spawnDelay = isIn2DInterstitial() ? (isMobileVR ? 1000 : 3000) : 0; | |||
There was a problem hiding this comment.
If I recall correctly the problem was that things would spawn up in the air above the user if their headset was on their forehead. If that's the case, fixing the spawn location seems like a better solution than adding a delay
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hack because Oculus Browser pauses all videos in the scene when exiting VR mode. It also flips on a 1s delay on spawning on for mobile VR browsers because when you exit VR mode the head orientation is locked (so if you were looking up at the hud, the object you spawn will be above your head).