explicitly switch between dynamic and static body types #401
Conversation
This should be a performance boost when there are many non-owned interactables in the scene because there are calculations that are run only on bodies set to dynamic in CANNON
| @@ -46,7 +46,7 @@ AFRAME.registerComponent("super-networked-interactable", { | |||
| this.hand = e.detail.hand; | |||
| if (this.networkedEl && !NAF.utils.isMine(this.networkedEl)) { | |||
| if (NAF.utils.takeOwnership(this.networkedEl)) { | |||
| this.el.setAttribute("body", { mass: this.data.mass }); | |||
| this.el.setAttribute("body", { type: "dynamic", mass: this.data.mass }); | |||
There was a problem hiding this comment.
Since we are actually toggling the type now we should be able to get rid of mass from this component's schema and just never touch the body's mass.
There was a problem hiding this comment.
toggling the type doesn't change the need for changing mass. Changing the mass is still required to get the behavior of switching between dynamic and static. Changing the type simply avoids unnecessary methods from being called on non-owned objects.
|
I just tried removing the mass property from |
This should be a performance boost when there are many non-owned interactables in the scene because there are calculations that are run only on bodies set to dynamic in CANNON. See instances of
if(this.type !== Body.DYNAMIC)in https://github.com/schteppe/cannon.js/blob/master/src/objects/Body.jsaframe-physics-systemPR to allow this here: n5ro/aframe-physics-system#97