Check if browser is an iOS uiWebView #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it is, don't allow user to enter in 2D. Instead, prompt the user to copy the URL and open it in Safari.
brianpeiris
reviewed
Jun 19, 2018
src/react-components/info-dialog.js
Outdated
| @@ -13,6 +13,7 @@ class InfoDialog extends Component { | |||
| slack: Symbol("slack"), | |||
| email_submitted: Symbol("email_submitted"), | |||
| invite: Symbol("invite"), | |||
| safari: Symbol(""), | |||
There was a problem hiding this comment.
Might as well use Symbol("safari") here. It makes for nicer debugging at least.
src/react-components/info-dialog.js
Outdated
| <button className="invite-form__action-button" onClick={this.shareLinkClicked}> | ||
| <span>Share</span> | ||
| </button> | ||
| )} |
There was a problem hiding this comment.
Does this actually show in Chrome? I would remove it.
src/react-components/info-dialog.js
Outdated
| dialogBody = ( | ||
| <div> | ||
| <div> | ||
| Hubs is not supported in your current browser on iOS. Copy and paste this link directly in Safari. |
There was a problem hiding this comment.
Nitpick: I think I'd prefer: "Hubs does not support your current browser on iOS."
src/react-components/info-dialog.js
Outdated
| <span>Share</span> | ||
| </button> | ||
| )} | ||
| <button className="invite-form__action-button" onClick={this.copyLinkClicked}> |
There was a problem hiding this comment.
copyLinkClicked will not include query parameters
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is, don't allow user to enter in 2D. Instead, prompt the user to copy the URL and open it in Safari. "fix" for #181