Cleanup main tick #5701
Merged
Cleanup main tick #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
force-pushed
the
cleanup-main-tick
branch
from
ab448f8 to
0f03d94
Compare
johnshaughnessy
approved these changes
Sep 12, 2022
| const aframeSystems = sceneEl.systems; | ||
| const hubsSystems = aframeSystems["hubs-systems"]; | ||
|
|
||
| // TODO does anything actually ever pause the scene? |
There was a problem hiding this comment.
I see that this check existed before, and has just been moved to here, but it seems like it would be a bug for anything to be able to pause the scene. At least -- I'm not aware of anything that would be doing that on purpose.
Along similar lines, perhaps we shouldn't start the mainTickuntil DOMContentDidLoad so we can remove the check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to consolidate everything that happens in a frame into 1 spot so its easy to see the order things are executing in. It also cleans up several pending TODOs around it, namely unifying the various timers we were using and getting rid of some more globals being stored on a-scene. This doesn't yet attempt to handle the TODOs in bit-camera-sytem around turning off
scene.autoUpdate(#5323). That feels like it warrants its own PR just because "matrix update bugs" are sneaky.This is probably easiest to review commit-by-commit since I tried to break them down into logical chunks and also the intermediate commits had NOTES that might be useful to read.