Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3D game functionality from scene page #5797

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

johnshaughnessy
Copy link
Contributor

We have regressed the scene page several times over the last few months. It's difficult to ensure correct behavior when loading the 3D game functionality because many files execute functionality on load that is not valid in the context of the scene page.

Until we bundle game functionality more carefully, it will be easier not to run any 3D game code on the scene page. That way, ongoing changes to the engine won't introduce new regressions.

@johnshaughnessy johnshaughnessy merged commit 8117da9 into master Nov 16, 2022
@johnshaughnessy johnshaughnessy deleted the feature/simplify-scene-page branch November 16, 2022 19:18
@johnshaughnessy johnshaughnessy mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant