Chat commands for fly mode & avatar size #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| <a-asset-item id="sound_asset-teleport_start" src="./assets/sfx/teleportArc.wav" response-type="arraybuffer" preload="auto"></a-asset-item> | ||
| <a-asset-item id="sound_asset-teleport_end" src="./assets/sfx/quickTurn.wav" response-type="arraybuffer" preload="auto"></a-asset-item> | ||
| <a-asset-item id="sound_asset-snap_rotate" src="./assets/sfx/quickTurn.wav" response-type="arraybuffer" preload="auto"></a-asset-item> | ||
| <a-asset-item id="sound_asset-snap_rotate" src="./assets/sfx/tap_mellow.wav" response-type="arraybuffer" preload="auto"></a-asset-item> |
There was a problem hiding this comment.
Oh, I thought the reception of quickTurn was positive.
There was a problem hiding this comment.
It's still on teleport end, which feels right since it sounds like you are moving rapidly. Dom mentioned the ratchet turn as something worth refining (if I read his message in discord right) and having been play testing it a bit I tend to think it's used often enough that the current sound is a bit much -- not strongly opposed to it but I think if you try this PR it feels better. (The tap sound here is now unique since I moved to an alternative, so the ratchet turn sound is still distinct)
brianpeiris
changed the title
brianpeiris
changed the title
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use slash (
/) commands in chat to enable fly mode, change your avatar size and more./help/leave/fly'/biggerand/smallerare supported. Easy to add more.