Don't whitelist CORS-blocked domains in dev #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, without this change, you can't paste any media or models from production Hubs.
The Jenkins job to build production already overrides this to have
hubs.mozilla.com,reticulum.ioso changing it here only affects local work.(By the way, this works because this environment variable is strange -- it's not actually a list of domains, it's a list of suffixes. Any domain that ends in one of these suffixes will be whitelisted. So
dev.reticulum.iomatches things likeuploads-dev.reticulum.io. We should fix this at some point.)