Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in changes from r103 #20

Merged
merged 739 commits into from
Apr 8, 2019
Merged

Pull in changes from r103 #20

merged 739 commits into from
Apr 8, 2019

Conversation

netpro2k
Copy link

No description provided.

mrdoob and others added 30 commits March 13, 2019 11:03
Editor: Added Manifest and ServiceWorker.
This deduplicates a lot of code that used to be the same in a lot of postprocessing passes.
The quad can be passed to renderer.render() directly without being a part of a scene.
GLTFLoader(jsm): Fix a remaining THREE ref
BufferGeometry: Honor morph targets when computing bounding volumes.
Add TypeScript definitions for example modules
…-jsm

Add TypeScript definitions for GLTFExporter
…ne_copy

Revert "Line: fix copy and clone methods"
@johnshaughnessy
Copy link

johnshaughnessy commented Apr 6, 2019

Nice that they added a guide about using dispose: https://threejs.org/docs/index.html#manual/en/introduction/How-to-dispose-of-objects

I wouldn't be surprised if we are missing some calls to dispose somewhere. I'd like to do a long-running memory profile test to see if / when we are leaking memory.

@netpro2k netpro2k merged commit f04f0bf into hubs/master Apr 8, 2019
@takahirox takahirox deleted the three-103 branch April 4, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.