Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2019/kw19/fix_form_user_input_event #83

Merged
merged 2 commits into from
May 7, 2019
Merged

2019/kw19/fix_form_user_input_event #83

merged 2 commits into from
May 7, 2019

Conversation

ulfgebhardt
Copy link
Member

@ulfgebhardt ulfgebhardt commented May 7, 2019 •
edited
Loading

Regarding Forms:
fixed user input event to be fired correctly, added reset event

Fixes: #46

@ulfgebhardt ulfgebhardt added bug Something isn't working enhancement New feature or request labels May 7, 2019
@ulfgebhardt ulfgebhardt added this to the 🏃 Sprint: Jupiter milestone May 7, 2019
@ulfgebhardt ulfgebhardt self-assigned this May 7, 2019
roschaefer
roschaefer approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

However, in order not to make this error ever again it would be great to safeguard this implementation with a test.

@ulfgebhardt ulfgebhardt merged commit 396e081 into master May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roschaefer roschaefer roschaefer approved these changes

@appinteractive appinteractive Awaiting requested review from appinteractive

Assignees

@ulfgebhardt ulfgebhardt

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
🏃 Sprint: Jupiter
Development

Successfully merging this pull request may close these issues.

DS-Form @input not emmitted
2 participants
@ulfgebhardt @roschaefer