Fix go.mod for Go 1.13+ #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlowe
force-pushed
the
feat/fix-go-mod
branch
from
c32a4e9 to
0af4048
Compare
Go 1.13 introduces stricter version checks. The timestamp for v0.0.0 dependencies must match the timestamp of the commit. Additionally, don't try to install tools with go modules support.
nlowe
force-pushed
the
feat/fix-go-mod
branch
from
0af4048 to
3cb18a3
Compare
|
@HylandSoftware/devops Please take a look at this when you get some time. |
jhindulak
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.13 introduces stricter version checks. The timestamp for v0.0.0 dependencies must match the timestamp of the commit. I've also disabled
GO111MODULEin theMakefilewhen we install tools. Without this Go wants to pull in all of their dependencies, and there's tons of breaking package renames that I don't feel like fighting with (it also adds a ton of time to the build).