Crypto design update #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sam Yuan <[email protected]>
SamYuan1990
force-pushed
the
CryptoUpdate
branch
from
df9290e to
c4e4e22
Compare
9 tasks
Signed-off-by: Sam Yuan <[email protected]>
davidkhala
reviewed
Apr 1, 2022
text/0000-modular-crypto-service.md
Outdated
| the benefits for this kind of refactor: | ||
| 1. When a new crypto curve is considered to be supported in Hyperledger Fabric, we can just make a BCCSP implementation and by addition an option in MSP level to make it. For ex: ed25519 | ||
| 1. For specific crypto curves, we can also support it by dynamic type, as a binary plugin of BCCSP and a MSP option to enable the binary plugin. For ex: Chinese national crypto curves. | ||
| 1. When MSP level interface is considered to add new logic, we don't need to worry it affects exisiting BCCSP logic and how the changes integrate with crypto related packages either bccsp or x509. For ex here, if we want to reduce the size of block by decouple peer cert. we are able to design and implement a mechanism like a pool below, plays role as cert pool identified by a hash string for cert bytes at MSP level. |
davidkhala
reviewed
Apr 1, 2022
text/0000-modular-crypto-service.md
Outdated
| // this is the public key of this instance | ||
| pk bccsp.Key | ||
| - [x] Redefine MSP responsibilities, as it relays on some crypto provide ex BCCSP interface implementation and response for fabric data model on business and logic level. | ||
| - [x] Redefine BSSP responsibilities, as it relays on crypto library implementation, plays role as adapter interface between MSP and cyrpto library implementations response for fabric data model on implementation level. |
Signed-off-by: Sam Yuan <[email protected]>
davidkhala
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft don't merge