Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to transports and allow developers to implement their own HTTP Clients #399

Merged
merged 41 commits into from
Jul 26, 2021

Conversation

ConnorLinfoot
Copy link
Member

@ConnorLinfoot ConnorLinfoot commented Feb 28, 2021

This update intends to remove forced built-in Apache dependency and instead allow users to select and handle their own HTTP implementation for communicating with the API including some premade transports.

There are also some other changes that have been made:

  • Removes deprecated methods (excluding the getPlayerByName method).
  • Rename getGameCounts to getCounts along with its new endpoint.
  • Rename getWatchdogStats to getPunishmentStats along with its new endpoint.
  • Moves to using a header for API Key authentication instead of a parameter.
  • ExampleUtil now supports a system property for easier testing with the API Key.

These changes are a work in progress and are subject to change before release.

@ConnorLinfoot ConnorLinfoot self-assigned this Feb 28, 2021
@ConnorLinfoot ConnorLinfoot added this to the v4.0.0 milestone May 9, 2021
@ConnorLinfoot ConnorLinfoot marked this pull request as ready for review May 10, 2021 12:42
@ConnorLinfoot ConnorLinfoot requested a review from Plancke May 10, 2021 12:42
@ConnorLinfoot ConnorLinfoot changed the title Hypixel Public API Java 4.0.0 Move to transports and allow developers to implement their own HTTP Clients May 10, 2021
Copy link

@CyberFlameGO CyberFlameGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Good idea!

@ConnorLinfoot ConnorLinfoot merged commit b20d501 into master Jul 26, 2021
@ConnorLinfoot ConnorLinfoot deleted the 4.0.0 branch July 26, 2021 11:41
@ConnorLinfoot ConnorLinfoot restored the 4.0.0 branch July 26, 2021 12:06
@ConnorLinfoot ConnorLinfoot deleted the 4.0.0 branch July 26, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants