Improve ability to generate duplicated values #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Sorry just realised I got distracted midway through commenting this code, so I'm going to do that now) |
Zalathar
reviewed
Dec 6, 2019
Comment on lines
654
to
657
| # Rather than make this the responsibility of individual strategies | ||
| # we implement a small mutator that just takes parts of the test | ||
| # case with the same label and tries replacing one of them with a | ||
| # copy of the other. |
There was a problem hiding this comment.
This will sound obvious, but I think this comment should explicitly state that we actually run the mutated data immediately after creating it.
That way the reader is more likely to look for (and find) the cached_test_function call that appears below.
|
The test failure should stop once #2262 is merged and this is rebased on top of it. |
DRMacIver
force-pushed
the
DRMacIver/duplication
branch
4 times, most recently
from
c8c5bbb to
75cfb04
Compare
DRMacIver
force-pushed
the
DRMacIver/duplication
branch
from
75cfb04 to
902ac47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to slim down
GenerationParametersa bit because it's rather too mysterious in operation (despite being an improvement on what came before!), so I wanted to get rid of thealphabetcode. This caused a small number of tests to fail, more or less as expected.The only major benefit of the alphabet code is that it helps us generate duplicates. So this PR adds a smol mutation step to generation that introduces duplication. This works better than the alphabet for creating duplicates because it also works for larger examples.
This did cause one test to fail which I just deleted, which was that it was possible to have all feature flags disabled. I thought about fixing that, and then I asked myself why that was a thing that we actually ever wanted to be possible, so I just deleted the test instead.