Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix is_hypothesis_file internal function #2313

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

vxgmichel
Copy link
Contributor

@vxgmichel vxgmichel commented Jan 10, 2020

This function used to incorrectly return True for files belonging to modules of the form hypothesis{suffix}. It now returns False for such files.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks great; just two comments on the surrounding stuff before I merge 😁

hypothesis-python/tests/cover/test_escalation.py Outdated Show resolved Hide resolved
hypothesis-python/RELEASE.rst Outdated Show resolved Hide resolved
@Zac-HD Zac-HD added bug something is clearly wrong here interop how to play nicely with other packages labels Jan 10, 2020
@vxgmichel vxgmichel force-pushed the fix-is-hypothesis-file branch 5 times, most recently from 0cd57fa to ed895e8 Compare January 10, 2020 17:19
@vxgmichel
Copy link
Contributor Author

I fixed a problem in the tests with python 3.5 but there seems to be another issue:

The job running on agent Azure Pipelines 14 ran longer than the maximum time of 60 minutes.

@Zac-HD
Copy link
Member

Zac-HD commented Jan 11, 2020

I fixed a problem in the tests with python 3.5 but there seems to be another issue:

#2308, not related to this change 😬

 Errors in third-party extensions such as `hypothesis-trio` or
 `hypothesis-jsonschema` used to be incorrectly considered to be
 Hypothesis internal errors, which could result in confusing error.
@Zac-HD Zac-HD force-pushed the fix-is-hypothesis-file branch from a836572 to ce791d4 Compare January 11, 2020 04:08
@Zac-HD Zac-HD closed this Jan 11, 2020
@Zac-HD Zac-HD reopened this Jan 11, 2020
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Fantastic work again - thanks @vxgmichel!

@Zac-HD Zac-HD merged commit 6f2d512 into HypothesisWorks:master Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is clearly wrong here interop how to play nicely with other packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants