Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address performance problems in new target selector code #922

Merged
merged 6 commits into from
Oct 8, 2017

Conversation

DRMacIver
Copy link
Member

@DRMacIver DRMacIver commented Oct 7, 2017

It turns out that:

This replaces our tags with hash-consed (i.e. memoized) objects, so that two value equal tags are always reference equal. This significantly speeds up their use as keys and set members.

Fixes #919.

@DRMacIver DRMacIver force-pushed the DRMacIver/targeting-performance branch from fd82153 to d5a9372 Compare October 7, 2017 18:30
@DRMacIver DRMacIver changed the title [WIP] Address performance problems in new target selector code Address performance problems in new target selector code Oct 7, 2017
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - it's pretty obvious what this is doing and why it helps. Take out the unused import of attrs in conjecture/engine.py, and go for it 🎉

@DRMacIver DRMacIver mentioned this pull request Oct 8, 2017
@DRMacIver DRMacIver merged commit 21e3153 into master Oct 8, 2017
@alexwlchan alexwlchan deleted the DRMacIver/targeting-performance branch October 8, 2017 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants