Skip to content

Commit

Permalink
[SPARK-32496][INFRA] Include GitHub Action file as the changes in tes…
Browse files Browse the repository at this point in the history
…ting

### What changes were proposed in this pull request?

apache#26556 excluded `.github/workflows/master.yml`. So tests are skipped if the GitHub Actions configuration file is changed.

As of SPARK-32245, we now run the regular tests via the testing script. We should include it to test to make sure GitHub Actions build does not break due to some changes such as Python versions.

### Why are the changes needed?

For better test coverage in GitHub Actions build.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

GitHub Actions in this PR will test.

Closes apache#29305 from HyukjinKwon/SPARK-32496.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
  • Loading branch information
HyukjinKwon committed Aug 18, 2020
1 parent 5809b04 commit d970a4d
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions dev/run-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,12 @@ def determine_modules_for_files(filenames):
['pyspark-core', 'sql']
>>> [x.name for x in determine_modules_for_files(["file_not_matched_by_any_subproject"])]
['root']
>>> [x.name for x in determine_modules_for_files( \
[".github/workflows/master.yml", "appveyor.yml"])]
>>> [x.name for x in determine_modules_for_files(["appveyor.yml"])]
[]
"""
changed_modules = set()
for filename in filenames:
if filename in (".github/workflows/master.yml", "appveyor.yml"):
if filename in ("appveyor.yml",):
continue
matched_at_least_one_module = False
for module in modules.all_modules:
Expand Down

0 comments on commit d970a4d

Please sign in to comment.