UID2-4808 Add azure-cc-aks protocol #1340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
force-pushed
the
kcc-UID2-4808-add-enclave-id-aks
branch
from
f1a8d8c to
023381f
Compare
cYKatherine
force-pushed
the
kcc-UID2-4808-add-enclave-id-aks
branch
2 times, most recently
from
8cf3425 to
21c462a
Compare
cYKatherine
force-pushed
the
kcc-UID2-4808-add-enclave-id-aks
branch
from
eb45e88 to
41d02b3
Compare
cYKatherine
commented
Feb 4, 2025
| validate_url("core_base_url", environment) | ||
| validate_url("optout_base_url", environment) | ||
| validate_operator_key() | ||
| # validate_url("core_base_url", environment) |
There was a problem hiding this comment.
ignore this for now, uncomment before merge
cYKatherine
commented
Feb 4, 2025
| String maaServerBaseUrl = this.config.getString(Const.Config.MaaServerBaseUrlProp, "https://sharedeus.eus.attest.azure.net"); | ||
| attestationProvider = AttestationFactory.getAzureCCAttestation(maaServerBaseUrl); | ||
| break; | ||
| case "azure-cc-aks": |
There was a problem hiding this comment.
QQ: We specify enclavePlatform in config, however, azure-cc and azure-cc-aks gets the same attestation provider. Do we still want to separate azure-cc and azure-cc-aks for enclavePlatform? It's quite confusing comapred to protocol in operator key, should we potentially make them a same thing in the future?
There was a problem hiding this comment.
I think it is fine since platform is different, attestation is same.
| String maaServerBaseUrl = this.config.getString(Const.Config.MaaServerBaseUrlProp, "https://sharedeus.eus.attest.azure.net"); | ||
| attestationProvider = AttestationFactory.getAzureCCAttestation(maaServerBaseUrl); | ||
| break; | ||
| case "azure-cc-aks": |
There was a problem hiding this comment.
cant we do
case "azure-cc", "azure-cc-aks":
cYKatherine
force-pushed
the
kcc-UID2-4808-add-enclave-id-aks
branch
from
6f2e3be to
499ea63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.