Remove hash from version #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
approved these changes
Apr 22, 2024
| echo "new_version=$NBGV_SimpleVersion-$NBGV_GitCommitIdShort-$BRANCH_NAME_TRUNC" >> $GITHUB_OUTPUT | ||
| elif [[ "${{ inputs.short_name }}" == "Yes" ]]; then | ||
| echo "new_version=$NBGV_SimpleVersion" >> $GITHUB_OUTPUT | ||
| echo "new_version=$NBGV_SimpleVersion-$BRANCH_NAME_TRUNC" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
What cases do we have with no version supplied and no pom.xml in the working dir? It looks like there's a risk for branch builds in that case - we'll go from having uniquely-identified branch releases to having conflicting ones for multiple releases on the same branch.
There was a problem hiding this comment.
Actually - I wasn't accounting for NBGV incrementing the version. I think we're fine.
lionell-pack-ttd
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the commit hash from version numbers as it is no longer necessary.
The snapshot version is now calculated to be x.y.z-alpha-n-SNAPSHOT where:
x and y are the current major and minor versions
z = current patch version plus one
n = GITHUB_RUN_NUMBER so that different branches from the same version do not have conflicting numbers.
Tested here:
https://github.com/IABTechLab/uid2-shared/actions/runs/8776854950
https://github.com/IABTechLab/uid2-core/actions/runs/8776987345