Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

definition of wetland emissions #226

Merged
merged 5 commits into from
Dec 6, 2024
Merged

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Dec 2, 2024

Updated definition of wetland emissions

Copy link
Contributor

@merfort merfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still keep the actual emission species in the description for consistency, see a suggestion inline.

Not sure how I feel about that this is the only variable where "net" is explicitly mentioned in the description...

definitions/variable/emissions/emissions.yaml Outdated Show resolved Hide resolved
definitions/variable/emissions/emissions.yaml Outdated Show resolved Hide resolved
definitions/variable/emissions/emissions.yaml Outdated Show resolved Hide resolved
flohump and others added 2 commits December 6, 2024 11:14
@flohump
Copy link
Contributor Author

flohump commented Dec 6, 2024

I'd still keep the actual emission species in the description for consistency, see a suggestion inline.

Not sure how I feel about that this is the only variable where "net" is explicitly mentioned in the description...

Thanks for the review and feedback.
I see your point on "net". "net" is correct but for consistency I removed it.

Copy link
Contributor

@merfort merfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good from my side

Copy link
Contributor

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay @flohump so if I understand this correctly, you want to quite clearly deviate from the IPCC 2006 reporting categories.
Meaning - 'all emissions related to wetland change: both converted to and converted from'.

Correct?

If so, then would be good to also update the one other Land category that will be affected by this change:
Emissions|{Level-3 Species}|AFOLU|Land|Other Land Use and Land-Use Change
... with something like '.... except under Land|Wetlands'

@flohump
Copy link
Contributor Author

flohump commented Dec 6, 2024

Okay @flohump so if I understand this correctly, you want to quite clearly deviate from the IPCC 2006 reporting categories. Meaning - 'all emissions related to wetland change: both converted to and converted from'.

Correct?

If so, then would be good to also update the one other Land category that will be affected by this change: Emissions|{Level-3 Species}|AFOLU|Land|Other Land Use and Land-Use Change ... with something like '.... except under Land|Wetlands'

No. The intention is to revise the definition such that it covers both _converted to_ and _converted from_.
The current definition only covers rewetted peatlands and excludes drained peatlands. But drained peatlands are by far the major source of GHG emissions from managed peatlands.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@danielhuppmann danielhuppmann merged commit 42fb54a into IAMconsortium:main Dec 6, 2024
5 checks passed
@jkikstra
Copy link
Contributor

jkikstra commented Dec 9, 2024

converted to and converted from

@flohump sorry to come back at this; but just to clarify. In my reading we both said the same?

The new variable contains "both converted to and converted from".

In IPCC categories, we have a category for each land type which includes:

  • YES: stay the same land category (3 B * a)
  • YES: converted to this land category (3 B * b)
  • NO: converted from this land category to another category (this falls under the (3 B * b) of a different land category)

So if you have, as you wrote in the description, also 3B1biii, 3B2biii and 3B3biii, 3B5biv, 3B6biv then could this create issues in the future with other variables?
For now, it could at minimum be good to do a minimal change in the description of Emissions|{Level-3 Species}|AFOLU|Land|Other Land Use and Land-Use Change to
"Emissions and removals from forest land, cropland, grassland, settlements, and other land that cannot be accommodated in other categories (partially IPCC 1996 category 5; IPCC 2006 category 3B except 3B1biii, 3B2biii, 3B3biii, 3B5biv, 3B6biv and 3B4)."

@flohump
Copy link
Contributor Author

flohump commented Dec 9, 2024

@jkikstra
Thanks! I now understand your point. I opened PR #236 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants