Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix livestock products definition for dairy <-> eggs #251

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Jan 16, 2025

Dairy is only milk and cheese but not eggs.
This PR fixes this issue by adding an extra category for eggs.

@jonathandoelman
Copy link

Hi Florian,
At the moment IMAGE does not report this separately (eggs are part of poultry), although we can add this distinction. Was there a specific request? Do you know if other models can (easily) report this?
Jonathan

@flohump
Copy link
Contributor Author

flohump commented Jan 20, 2025

Hi Florian, At the moment IMAGE does not report this separately (eggs are part of poultry), although we can add this distinction. Was there a specific request? Do you know if other models can (easily) report this? Jonathan

No, there was no specifc request for an egg category. Rather, I became aware of the fact that dairy does ony inlcude milk and cheese, but not eggs. I made this mistake when splitting-up livestock categories in November.

As an alternative, we can put eggs into Non-Ruminant livestock products.
I would be completely fine with that.
We could add eggs as subcategory in Non-Ruminant livestock products for those teams who can report on it.
What do you think?

@jonathandoelman
Copy link

Hi Florian, At the moment IMAGE does not report this separately (eggs are part of poultry), although we can add this distinction. Was there a specific request? Do you know if other models can (easily) report this? Jonathan

No, there was no specifc request for an egg category. Rather, I became aware of the fact that dairy does ony inlcude milk and cheese, but not eggs. I made this mistake when splitting-up livestock categories in November.

As an alternative, we can put eggs into Non-Ruminant livestock products. I would be completely fine with that. We could add eggs as subcategory in Non-Ruminant livestock products for those teams who can report on it. What do you think?

Ah I see, IMAGE already reports it as part of the Non-Ruminant category. Now I am thinking about it that also makes sense as it is a poultry product. Dairy is part of the Ruminant category, right? Adding a non-ruminant|eggs category does sounds like a nice plan as well.

@flohump
Copy link
Contributor Author

flohump commented Jan 20, 2025

At the moment we have
Agricultural Demand|Livestock|Food|Dairy - Demand for livestock products used as food - dairy products (milk, eggs)
Agricultural Demand|Livestock|Food|Non-Ruminant - Demand for livestock products used as food - monogastric meat (pig, poultry)
Agricultural Demand|Livestock|Food|Ruminant - Demand for livestock products used as food - ruminant meat (cattle, goat, sheep)
see https://github.com/IAMconsortium/common-definitions/blob/main/definitions/variable/afolu/tag_livestock.yaml

Based on our discussion, I suggest to change it to:
Agricultural Demand|Livestock|Food|Pig - Demand for livestock products used as food - pig meat
Agricultural Demand|Livestock|Food|Poultry - Demand for livestock products used as food - poultry peat and eggs
Agricultural Demand|Livestock|Food|Poultry|Eggs - Demand for livestock products used as food - eggs
Agricultural Demand|Livestock|Food|Ruminant - Demand for livestock products used as food - ruminant meat (cattle, goat, sheep) and dairy products (milk, cheese)
Agricultural Demand|Livestock|Food|Ruminant|Meat - Demand for livestock products used as food - ruminant meat (cattle, goat, sheep)
Agricultural Demand|Livestock|Food|Ruminant|Dairy - Demand for livestock products used as food - dairy products (milk, cheese)

If we change the tags in line with this, it will also affect the following variables:
Agricultural Production
Trade|Agriculture
Food Availability
Food Intake

What do you think?

@jonathandoelman
Copy link

hmm, this would imply quite a big change and make the reporting not backward compatible. this is of course not essential, but this change is also not very highly needed. we could also have a compromise that maintains the non-ruminant category but also adds the extra detail:
Agricultural Demand|Livestock|Food|Non-Ruminant|Pig Meat- Demand for livestock products used as food - pig meat
Agricultural Demand|Livestock|Food|Non-Ruminant|Poultry Meat- Demand for livestock products used as food - poultry peat and eggs
Agricultural Demand|Livestock|Food|Non-Ruminant|Poultry Eggs - Demand for livestock products used as food - eggs
Agricultural Demand|Livestock|Food|Ruminant - Demand for livestock products used as food - ruminant meat (cattle, goat, sheep) and dairy products (milk, cheese)
Agricultural Demand|Livestock|Food|Ruminant|Meat - Demand for livestock products used as food - ruminant meat (cattle, goat, sheep)
Agricultural Demand|Livestock|Food|Ruminant|Dairy - Demand for livestock products used as food - dairy products (milk, cheese)

@flohump
Copy link
Contributor Author

flohump commented Jan 20, 2025

Thanks! I adopted your suggestion. Please review my code.

Copy link

@jonathandoelman jonathandoelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@danielhuppmann danielhuppmann merged commit 90428f1 into IAMconsortium:main Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants