-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix livestock products definition for dairy <-> eggs #251
Conversation
Hi Florian, |
No, there was no specifc request for an egg category. Rather, I became aware of the fact that As an alternative, we can put eggs into |
Ah I see, IMAGE already reports it as part of the Non-Ruminant category. Now I am thinking about it that also makes sense as it is a poultry product. Dairy is part of the Ruminant category, right? Adding a non-ruminant|eggs category does sounds like a nice plan as well. |
At the moment we have Based on our discussion, I suggest to change it to: If we change the tags in line with this, it will also affect the following variables: What do you think? |
hmm, this would imply quite a big change and make the reporting not backward compatible. this is of course not essential, but this change is also not very highly needed. we could also have a compromise that maintains the non-ruminant category but also adds the extra detail: |
Thanks! I adopted your suggestion. Please review my code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Dairy is only milk and cheese but not eggs.
This PR fixes this issue by adding an extra category for eggs.