Review: 1572-implement-changes-in-formbuilder #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PG-Momik
commented
Nov 5, 2024
PG-Momik
commented
- Activity
- Result
- Indicator
- Period
- Tramsacton
- Organisation
- Indentation fixes
- Added collapsable button
- Hiding add button
- Improve error message detection
- Fix: scroll effect not working
- Fix: frozen field not closed
- Fix: transaction not open
- Fix: Period detail breadcrumb
- Fix: Transaction detail breadcrumb
- Changes from emma's comment
12 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
PG-Momik
force-pushed
the
1572-implement-changes-in-formbuilder
branch
from
1b22253 to
500db98
Compare
- [x] Result - [x] Indicator - [x] Period - [x] Tramsacton - [x] Organisation - [x] Indentation fixes - [x] Added collapsable button - [x] Hiding add button - [x] Improve error message detection - [x] Fix: scroll effect not working - [x] Fix: frozen field not closed - [x] Fix: transaction not open - [x] Fix: Period detail breadcrumb - [x] Fix: Transaction detail breadcrumb - [x] Changes from emma's comment - [x] Code factor changes
PG-Momik
force-pushed
the
1572-implement-changes-in-formbuilder
branch
from
500db98 to
a4ec932
Compare
Sanilblank
approved these changes
Nov 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.