Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: 1567-check-expected-behaviour-of-publishing-progress-box-when-exiting-to-view-data-quality-issues #1740

Conversation

Yash-ftW
Copy link
Collaborator

-[x] New Tab Popup Close Fix, Flow Change Bulk Publish
-[x] WIP Bulk Publish Progress
-[x] Added top_level_error in validator status check response -[x] Added Critical Error Check
-[x] Select All Fixing
-[x] Disabled Checkbox for Critical Errored Activitities -[x] Added skipping critical error activities on publish -[x] Fix not writing in db
-[x] Disabled Select All
-[x] Uncommented Test
-[x] Added Open in new Tab Text
-[x] Added Screenshot for completeness
-[x] Minimize While Bulk Publish Fixes
-[x] Added Title Ellipsis When Longer Title
-[x] Truncated Title
-[x] 0 Value Test
-[x] Fix 0 Issue Showing
-[x] Support Button When Open New Tab Position Issue -[x] Text Changes
-[x] Step shown for only error
-[x] Text Changes, Removed Open in New Tab if no Error -[x] Refresh when Close last step
-[x] ORG Type Capitalized for Superadmin
-[x] Not showing warning on error type warning, Text changes -[x] Removed Refresh Toast Message
-[x] Added Back Refresh Toast
-[x] Message Changes
-[x] Removed Warning For Advisory
-[x] Advisory Fixing
-[x] Text Changes

-[x] WIP Bulk Publish Progress
-[x] Added top_level_error in validator status check response
-[x] Added Critical Error Check
-[x] Select All Fixing
-[x] Disabled Checkbox for Critical Errored Activitities
-[x] Added skipping critical error activities on publish
-[x] Fix not writing in db
-[x] Disabled Select All
-[x] Uncommented Test
-[x] Added Open in new Tab Text
-[x] Added Screenshot for completeness
-[x] Minimize While Bulk Publish Fixes
-[x] Added Title Ellipsis When Longer Title
-[x] Truncated Title
-[x] 0 Value Test
-[x] Fix 0 Issue Showing
-[x] Support Button When Open New Tab Position Issue
-[x] Text Changes
-[x] Step shown for only error
-[x] Text Changes, Removed Open in New Tab if no Error
-[x] Refresh when Close last step
-[x] ORG Type Capitalized for Superadmin
-[x] Not showing warning on error type warning, Text changes
-[x] Removed Refresh Toast Message
-[x] Added Back Refresh Toast
-[x] Message Changes
-[x] Removed Warning For Advisory
-[x] Advisory Fixing
-[x] Text Changes
@Yash-ftW Yash-ftW requested a review from PG-Momik January 28, 2025 04:45
Copy link

what-the-diff bot commented Jan 28, 2025

PR Summary

  • Introduced BulkPublishCacheHelper class: This new addition helps manage cache related to bulk publishing, providing abilities to read, adjust and reset the cache data associated with extensive publishing tasks.

  • Enhanced BulkPublishingController and BulkPublishingService: The controller now uses the methods provided by BulkPublishCacheHelper to manage the cache during bulk publishing. It now also has the capability to detect changes in activities. The service can now filter out publishable activities that do not have critical errors.

  • Observer Updates: ActivityObserver, ResultObserver, and TransactionObserver classes now only add activity IDs to the cache when a large scale publish is in progress.

  • Adjusted ImportActivityController and ValidationStatusRepository: Removed unneeded logging from the controller and added retrieval functionality of IDs for error-free activity in the repository.

  • Added a new component BulkPublishRevalidatePopup.vue: This new part manages user notifications regarding data changes, providing cancel and revalidate options.

  • Interface Updates:

    • Updated various visualization components and adjusted error display mechanisms based on a new property (top_level_error) and to only show non-advisory errors.
    • Streamlined UI elements and changed a number of labels and placeholder text to improve user understanding.
    • Incorporated the BulkPublishRevalidatePopup component to handle data changes and revalidation.
  • Updated mix-manifest.json: The updates to this file show that there have been changes in files used by the website.

  • Route adjustments: Added a new route for detecting changes in activities and fine-tuned existing ones for better validation status handling.

  • Added an SVG file: A new icon has been added for use within the application.

  • General UI updates: Modified wording for data quality issues warning and button disabled state. Also added reactive handling to track and store validation progress.

Please note: Minor changes like removing unnecessary console logs and negligible changes to user interface components have been skipped in this summary.

@PG-Momik PG-Momik merged commit a17d277 into main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check expected behaviour of publishing progress box when exiting to view data quality issues
2 participants